Enable stylecheck linter #2505
Merged
Enable stylecheck linter #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viveksinghggits
requested changes
Jul 12, 2024
viveksinghggits
requested changes
Jul 12, 2024
viveksinghggits
approved these changes
Jul 23, 2024
Co-authored-by: Vivek Singh <vsingh.ggits.2010@gmail.com>
PrasadG193
reviewed
Jul 29, 2024
| @@ -12,6 +12,7 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| // Package repositoryserver validates the secret credentials for all location profiles. | |||
There was a problem hiding this comment.
[question] Do we have a lint checker for comment on package name? I don't think that is necessary
There was a problem hiding this comment.
Yes, it is. ST1000(stylecheck linter). It says we should describe package about what its doing in any one file atleast. Although I have disabled this ST1000 in this PR, but had already made this change, so decided to keep the description as it is and later on ST1000 will be enabled as a part of another PR will add similar description for other packages as well.
There was a problem hiding this comment.
@PrasadG193 Checked kubernates repository. Found few examples where this linter is handled:
- https://github.com/kubernetes/kubernetes/blob/0fc167103189a4d462c3cc7a17b360c3d998f4bf/cmd/kube-apiserver/app/options/options.go#L17
- https://github.com/kubernetes/kubernetes/blob/0fc167103189a4d462c3cc7a17b360c3d998f4bf/cmd/kube-apiserver/app/aggregator.go#L17
- https://github.com/kubernetes/kubernetes/blob/0fc167103189a4d462c3cc7a17b360c3d998f4bf/cmd/kube-apiserver/apiserver.go#L17
PrasadG193
requested changes
Jul 29, 2024
PrasadG193
approved these changes
Jul 29, 2024
|
@saima-s let's merge 🚀 it. |
Will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR enables stylecheck golang linter
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan